fix(network): Respond to getheaders requests with a maximum of 160 block headers #8913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arya2
added
C-bug
upbqdn
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a bug in Zebra's network protocol implementation where Zebra will return fewer than the expected maximum number of block headers in response to getheaders requests which has been falsely indicating to peers that they have reached the tip of Zebra's chain.
This doesn't strictly block the release if we want to also ignore getheaders requests during Zebra's initial sync.
Closes #8907.
Solution
PR Author's Checklist
PR Reviewer's Checklist